Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use internal bun drv and bun 1.0.1 #99

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Conversation

cdmistman
Copy link
Contributor

Why

been getting a lot of bumps about updating bun package for replit, but relying on upstream nixpkgs for this means we actually lose 2 workdays (not including weekends) every time there's a release before we're caught up on bun versions

we'll just internally maintain a duplicate version of the bun derivation from upstream, but once the hype dies down we'll want to remove it and rely on upstream

What changed

  • brought the bun derivation file into this repo
  • use the internal derivation for bun module
  • update bun to 1.0.1

Test plan

  • install bun-1.0 module v2
  • bun --version prints 1.0.1

Rollout

Describe any procedures or requirements needed to roll this out safely (or check the box below)

  • This is fully backward and forward compatible

@cdmistman cdmistman requested a review from a team as a code owner September 13, 2023 15:34
@cdmistman cdmistman requested review from masad-frost and removed request for a team September 13, 2023 15:34
@cdmistman cdmistman force-pushed the cad/use-internal-bun-drv branch 2 times, most recently from e4678d3 to 9467cf7 Compare September 13, 2023 16:52
pkgs/modules/bun/bun.nix Outdated Show resolved Hide resolved
@cdmistman cdmistman force-pushed the cad/use-internal-bun-drv branch from 9467cf7 to 9aaa2a2 Compare September 13, 2023 17:11
@cdmistman cdmistman changed the base branch from main to cad/go-make-file-param-optional September 13, 2023 17:12
Base automatically changed from cad/go-make-file-param-optional to main September 13, 2023 17:12
@cdmistman cdmistman requested a review from ryantm September 13, 2023 17:19
@cdmistman cdmistman merged commit 143e1ed into main Sep 13, 2023
1 check passed
@cdmistman cdmistman deleted the cad/use-internal-bun-drv branch September 13, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants